Improvement #757
closed
Don't use Anonymous Inner Classes
Added by Federico Vera over 7 years ago. Updated over 7 years ago.
100%
Description
There're some annoying issues when using Anonymous Inner Classes:
- Can't serialize (we actually need this)
- Not easily optimizable by compiler (since methods are overridable they are called using
invokedinamic) - Code seems confusing for some people.
Updated by Federico Vera over 7 years ago
Actions
#1
- Blocks Improvement #749: Hacer que las expresiones sean serializables added
Updated by Federico Vera over 7 years ago
Actions
#2
Changeset: fcc2589e815a5387a13c4d5b96f1c23e63e365b8
Author: Federico Vera [email protected]
Date: 2018-07-12 08:37
Message: Make Funtions static inner classes instead of Anonymous Inner Clasess
Updated by Federico Vera over 7 years ago
Actions
#3
Changeset: 6a5a3fe233668589c9225cda8afb2aa56862595c
Author: Federico Vera [email protected]
Date: 2018-07-12 08:37
Message: Make Operators static inner classes instead of Anonymous Inner Clasess
Updated by Federico Vera over 7 years ago
Actions
#4
Changeset: a3c3e9fa66ffcc0eb8d3ee22c43ed68bec61c236
Author: Federico Vera [email protected]
Date: 2018-07-12 08:39
Message: Don't use an array as backend for Functions
Updated by Federico Vera over 7 years ago
Actions
#5
Changeset: 5602321cc8d9ab93087e8b85d4bc7398af96c7a5
Author: Federico Vera [email protected]
Date: 2018-07-12 09:08
Message: Don't use an array as backend for Operators
Updated by Federico Vera over 7 years ago
Actions
#6
Changeset: d7b8e40ce99892c5a053ea53ae2f097a46fefb23
Author: Federico Vera [email protected]
Date: 2018-07-12 09:14
Message: Make FunctionsMisc static inner classes instead of Anonymous Inner Clasess
Updated by Federico Vera over 7 years ago
Actions
#7
Changeset: eb3062b6dde94f7caaa514bc6699ec2ba3031207
Author: Federico Vera [email protected]
Date: 2018-07-12 09:25
Message: Make FunctionsBoolean static inner classes instead of Anonymous Inner Clasess
Updated by Federico Vera over 7 years ago
Actions
#8
Changeset: 872320f62d7e7e90f8a92aaf0b1905d72a87dc98
Author: Federico Vera [email protected]
Date: 2018-07-12 09:43
Message: Make OperatorsComparison static inner classes instead of Anonymous Inner Clasess
Updated by Federico Vera over 7 years ago
Actions
#9
- Status changed from New to Resolved
- % Done changed from 0 to 100
Listo, hubo unas cuantas mejoras en performance:
Performance¶
In Java 8¶
Running net.objecthunter.exp4j.PerformanceTest
+------------------------+---------------------------+--------------------------+
| Implementation | Calculations per Second | Percentage of Math |
+------------------------+---------------------------+--------------------------+
| Java Math | 3368046.50 | 100.0000 % |
| exp4j | 1524782.00 | 45.2720 % |
| exp4j simplified | 1643364.50 | 48.7928 % |
| JSR-223 (Java Script) | 1375017.00 | 40.8254 % |
+------------------------+---------------------------+--------------------------+
In Java 10¶
Running net.objecthunter.exp4j.PerformanceTest
+------------------------+---------------------------+--------------------------+
| Implementation | Calculations per Second | Percentage of Math |
+------------------------+---------------------------+--------------------------+
| Java Math | 3183812.50 | 100.0000 % |
| exp4j | 1856690.00 | 58.3166 % |
| exp4j simplified | 2016287.50 | 63.3293 % |
| JSR-223 (Java Script) | 1810797.50 | 56.8751 % |
+------------------------+---------------------------+--------------------------+
Updated by Federico Vera over 7 years ago
Actions
#10
- Tracker changed from Development to Improvement