Project

General

Profile

Mejora #752

Implement evaluation cache

Added by Federico Vera about 2 years ago. Updated about 2 years ago.

Status:
Resuelto
Priority:
Wishlist
Assignee:
Target version:
Start date:
2018-07-10
Due date:
2018-08-01
% Done:

100%

Estimated time:
Dificultad:

Description

As of now, every call to Expression#evaluate() reevaluates the whole expression.
This isn't a problem in and of itself, but it's a common error when using the library and creates an annoying performance hit.

  • Find all scenarios where this could fail
  • If an expression contains non-deterministic results, the value should not be cached
  • Cache should be cleaned if variable changes
  • What happens when using setVariables() with maps?
  • Create tests for expression evaluate

PS: We attempted to fix this with documentation and warnings... but still creates a problem. An internal (at least partial) solution shouldn't be hard to accomplish... I think...

#1

Updated by Federico Vera about 2 years ago

  • Tracker changed from Desarrollo to Mejora
  • Priority changed from Normal to Wishlist
#2

Updated by Federico Vera about 2 years ago

  • Target version changed from 0.7 to 1.0
#3

Updated by Federico Vera about 2 years ago

  • Description updated (diff)

Scenarios to fail:

  • Multiple async calls (will fail anyway)
  • Non deterministic functions
#4

Updated by Federico Vera about 2 years ago

  • % Done changed from 0 to 70
#5

Updated by Federico Vera about 2 years ago

  • Status changed from Nuevo to Resuelto
  • % Done changed from 70 to 100

Also available in: Atom PDF

Go to top